From bb0bfc1dfdb28f09c6d465c9d0dfd0f9d7d9f0f2 Mon Sep 17 00:00:00 2001 From: Last2014 Date: Thu, 19 Mar 2026 11:42:38 +0900 Subject: [PATCH] =?UTF-8?q?Chg:=20ConfigRepository.get=E3=81=AEreturn?= =?UTF-8?q?=E3=82=92Entity=E3=81=AB=20/=20Chg:=20setup/initilization?= =?UTF-8?q?=E3=82=92=E3=81=AEconfig=E6=93=8D=E4=BD=9C=E3=82=92Repository?= =?UTF-8?q?=E3=81=AB=20/=20Fix:=20setup/create-admin=E3=81=AE=E9=87=8D?= =?UTF-8?q?=E8=A4=87=E3=83=81=E3=82=A7=E3=83=83=E3=82=AF=E3=82=92=E8=A7=A3?= =?UTF-8?q?=E6=B6=88?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../backend/src/modules/repositories/Config.ts | 4 +--- .../backend/src/routes/setup/create-admin.ts | 17 ----------------- .../backend/src/routes/setup/initialization.ts | 10 +++++----- 3 files changed, 6 insertions(+), 25 deletions(-) diff --git a/packages/backend/src/modules/repositories/Config.ts b/packages/backend/src/modules/repositories/Config.ts index a4a56cd..39d8bda 100644 --- a/packages/backend/src/modules/repositories/Config.ts +++ b/packages/backend/src/modules/repositories/Config.ts @@ -3,12 +3,10 @@ import type { ConfigEntity } from "@/modules/entities/Config"; export class ConfigRepository extends EntityRepository { async set(name: string, value: string) { - await this.upsert({ + return await this.upsert({ name, value, }); - - return; } async get(name: string, defaultValue?: string) { diff --git a/packages/backend/src/routes/setup/create-admin.ts b/packages/backend/src/routes/setup/create-admin.ts index 64b65e5..ffbe2eb 100755 --- a/packages/backend/src/routes/setup/create-admin.ts +++ b/packages/backend/src/routes/setup/create-admin.ts @@ -3,7 +3,6 @@ import logger from "@/lib/logger"; import type { FastifyInstance } from "fastify"; import { UserRepository } from "@/modules/repositories/User"; import { DatabaseError, ErrorBase, InputError } from "@/errors"; -import { ConfigEntity } from "@/modules/entities/Config"; export default function CreateAdmin(fastify: FastifyInstance) { fastify.post("/", async (req, res) => { @@ -15,22 +14,6 @@ export default function CreateAdmin(fastify: FastifyInstance) { return res.code(400).send(InputError(result.error.issues)); } - try { - const configCount = await fastify.orm.em.count(ConfigEntity); - - if (configCount === 0) { - return res.code(409).send(ErrorBase({ - bad: "client", - code: "yet_initialization", - message: "初期設定が行われていません。", - })); - } - } catch (err) { - logger.error("Database Error: Could not check if already initialization:", err); - - return res.code(500).send(DatabaseError()); - } - try { const userCount = await fastify.orm.em.getRepository(UserEntity).count(); diff --git a/packages/backend/src/routes/setup/initialization.ts b/packages/backend/src/routes/setup/initialization.ts index 3dd7496..a3d2435 100644 --- a/packages/backend/src/routes/setup/initialization.ts +++ b/packages/backend/src/routes/setup/initialization.ts @@ -46,12 +46,12 @@ export default function Initialization(fastify: FastifyInstance) { const entries = Object.entries(result.data).filter(([key]) => key !== "force"); for (const [key, value] of entries) { - const entity = fastify.orm.em.create(ConfigEntity, { - name: key, - value: typeof value === "string" + const entity = fastify.orm.em.getRepository(ConfigEntity).set( + key, + typeof value === "string" ? value - : String(value), - }); + : String(value) + ); fastify.orm.em.persist(entity); }